Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash.XxHash #12635

Closed
bep opened this issue Jul 3, 2024 · 1 comment · Fixed by #12636
Closed

Add hash.XxHash #12635

bep opened this issue Jul 3, 2024 · 1 comment · Fixed by #12636
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.129.0

Comments

@bep
Copy link
Member

bep commented Jul 3, 2024

Also move the non crypto hash funcs into this new package.

https://github.com/cespare/xxhash
@bep bep added the Enhancement label Jul 3, 2024
@bep bep added this to the v0.129.0 milestone Jul 3, 2024
@bep bep self-assigned this Jul 3, 2024
bep added a commit to bep/hugo that referenced this issue Jul 3, 2024
@bep
Add hash.XxHash
8679a33 
Also move the non crypto hash funcs into this new package.

This is much faster than e.g. MD5, especially for larger inputs:

```
BenchmarkXxHash/xxHash_43-10         	 9611962	       114.2 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/xxHash_4300-10       	 3010317	       397.3 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_43-10           	 5566405	       214.1 ns/op	     128 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_4300-10         	  163681	      7432 ns/op	    4944 B/op	       4 allocs/op
```

Fixes gohugoio#12635
@bep bep mentioned this issue Jul 3, 2024
Merged
bep added a commit to bep/hugo that referenced this issue Jul 3, 2024
@bep
Add hash.XxHash
441e558 
Also move the non crypto hash funcs into this new package.

This is much faster than e.g. MD5, especially for larger inputs:

```
BenchmarkXxHash/xxHash_43-10         	 9611962	       114.2 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/xxHash_4300-10       	 3010317	       397.3 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_43-10           	 5566405	       214.1 ns/op	     128 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_4300-10         	  163681	      7432 ns/op	    4944 B/op	       4 allocs/op
```

Fixes gohugoio#12635
bep added a commit to bep/hugo that referenced this issue Jul 3, 2024
@bep
Add hash.XxHash
fe143de 
Also move the non crypto hash funcs into this new package.

This is much faster than e.g. MD5, especially for larger inputs:

```
BenchmarkXxHash/xxHash_43-10         	 9611962	       114.2 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/xxHash_4300-10       	 3010317	       397.3 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_43-10           	 5566405	       214.1 ns/op	     128 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_4300-10         	  163681	      7432 ns/op	    4944 B/op	       4 allocs/op
```

Fixes gohugoio#12635
bep added a commit to bep/hugo that referenced this issue Jul 3, 2024
@bep
Add hash.XxHash
8d45b33 
Also move the non crypto hash funcs into this new package.

This is much faster than e.g. MD5, especially for larger inputs:

```
BenchmarkXxHash/xxHash_43-10         	 9917955	       112.2 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_43-10           	 6017239	       204.1 ns/op	      96 B/op	       3 allocs/op
BenchmarkXxHash/fnv32a_43-10         	14407333	        82.30 ns/op	      16 B/op	       1 allocs/op
BenchmarkXxHash/xxHash_4300-10       	 2916892	       409.7 ns/op	      56 B/op	       4 allocs/op
BenchmarkXxHash/mdb5_4300-10         	  159748	      7491 ns/op	    4912 B/op	       3 allocs/op
BenchmarkXxHash/fnv32a_4300-10       	  218210	      5510 ns/op	      16 B/op	       1 allocs/op
```

Fixes gohugoio#12635
@bep bep closed this as completed in #12636 Jul 6, 2024
@bep bep closed this as completed in 644d554 Jul 6, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.129.0
Development

Successfully merging a pull request may close this issue.

Add hash.XxHash bep/hugo
1 participant
@bep