Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the file cache for resources.GetRemote #12502

Closed
bep opened this issue May 16, 2024 · 1 comment · Fixed by #12523
Closed

Improve the file cache for resources.GetRemote #12502

bep opened this issue May 16, 2024 · 1 comment · Fixed by #12523
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.127.0

Comments

@bep
Copy link
Member

bep commented May 16, 2024

The new Content Adapters work great, but the caching setup leaves something to be desired, and this is especially true for server edits.

I suggest that we add a HTTP cache wrapper (e.g. this https://github.com/gregjones/httpcache) and, when the server is running:

  • Add a "HTTP stale checker" in its own goroutine.
  • If any stale remote resources is found, pass these identities to Hugo's partial rebuild.
@bep bep added the Proposal label May 16, 2024
@bep bep added this to the v0.127.0 milestone May 16, 2024
@bep bep self-assigned this May 16, 2024
@bep bep added Enhancement and removed Proposal labels May 17, 2024
bep added a commit to bep/hugo that referenced this issue May 20, 2024
@bep
Add a HTTP cache for remote resources.
ff47fd5 
Fixes gohugoio#12502
@bep bep mentioned this issue May 20, 2024
Merged
bep added a commit to bep/hugo that referenced this issue May 20, 2024
@bep
Add a HTTP cache for remote resources.
a8740c7 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 21, 2024
@bep
Add a HTTP cache for remote resources.
a3b076e 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 21, 2024
@bep
Add a HTTP cache for remote resources.
454e2d1 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 21, 2024
@bep
Add a HTTP cache for remote resources.
99b0906 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 21, 2024
@bep
Add a HTTP cache for remote resources.
db3f8bf 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 21, 2024
@bep
Add a HTTP cache for remote resources.
fdfb64d 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 22, 2024
@bep
Add a HTTP cache for remote resources.
538c0bb 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 22, 2024
@bep
Add a HTTP cache for remote resources.
a9eb6ce 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue May 22, 2024
@bep
Add a HTTP cache for remote resources.
4dc5f74 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 2, 2024
@bep
Add a HTTP cache for remote resources.
c2e305c 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
4ce9814 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
e7cf149 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
9548204 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
e53d046 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
fd4929a 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
e2fe02f 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
64ae07e 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 3, 2024
@bep
Add a HTTP cache for remote resources.
9ed0c9a 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 4, 2024
@bep
Add a HTTP cache for remote resources.
2095583 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 4, 2024
@bep
Add a HTTP cache for remote resources.
0fa8371 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 4, 2024
@bep
Add a HTTP cache for remote resources.
c8dddcf 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 4, 2024
@bep
Add a HTTP cache for remote resources.
3a6bb92 
Fixes gohugoio#12502
bep added a commit to bep/hugo that referenced this issue Jun 4, 2024
@bep
Add a HTTP cache for remote resources.
47eaba7 
Fixes gohugoio#12502
Closes gohugoio#11891
@bep bep closed this as completed in 447108f Jun 4, 2024
bep added a commit that referenced this issue Jun 5, 2024
@bep
Misc rmote HTTP/content adapter enhancements
e45af0a 
* Recover from server errors
* Improve go adapter rebuilds when adding new content

See #12502
Fixes #12570
@bep bep mentioned this issue Jun 5, 2024
Merged
bep added a commit that referenced this issue Jun 5, 2024
@bep
Misc remote HTTP/content adapter enhancements
7660d58 
* Recover from server errors
* Improve go adapter rebuilds when adding new content

See #12502
Fixes #12570
bep added a commit that referenced this issue Jun 5, 2024
@bep
Misc remote HTTP/content adapter enhancements
5bf44cb 
* Recover from server errors
* Improve go adapter rebuilds when adding new content

See #12502
Fixes #12570
bep added a commit that referenced this issue Jun 5, 2024
@bep
Misc remote HTTP/content adapter enhancements
6389adc 
* Recover from server errors
* Improve go adapter rebuilds when adding new content

See #12502
Fixes #12570
bep added a commit that referenced this issue Jun 5, 2024
@bep
Misc remote HTTP/content adapter enhancements
2b05a50 
* Recover from server errors
* Improve go adapter rebuilds when adding new content

See #12502
Fixes #12570
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.127.0
Development

Successfully merging a pull request may close this issue.

Add a HTTP cache for remote resources. bep/hugo
1 participant
@bep