Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl/tplimpl: Improve locale value in opengraph.html #12480

Closed
jmooring opened this issue May 10, 2024 · 1 comment · Fixed by #12482
Closed

tpl/tplimpl: Improve locale value in opengraph.html #12480

jmooring opened this issue May 10, 2024 · 1 comment · Fixed by #12482

Comments

@jmooring
Copy link
Member

{{- with or .Params.locale site.Language.LanguageCode site.Language.Lang }}
<meta property="og:locale" content="{{ . }}">
{{- end }}

Improvements:

  1. With v0.112.0 and later, site.Language.LanguageCode falls back to site.Language.Lang, so the explicit fallback above is not required.
  2. Contrary to RFC 5646, the opengraph protocol requires an underscore instead of a hyphen in the locale.

Proposed change:

{{- with or .Params.locale site.Language.LanguageCode }}
  <meta property="og:locale" content="{{ replace . `-` `_` }}">
{{- end }}
Copy link

github-actions bot commented Jun 5, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants