Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if logging to file somehow got lost #11071

Closed
bep opened this issue Jun 5, 2023 · 5 comments · Fixed by #11088
Closed

Check if logging to file somehow got lost #11071

bep opened this issue Jun 5, 2023 · 5 comments · Fixed by #11088
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Jun 5, 2023

No description provided.

@bep bep added the Bug label Jun 5, 2023
@bep bep self-assigned this Jun 5, 2023
@bep bep modified the milestones: v0.113.0, v0.113.1 Jun 5, 2023
@jmooring
Copy link
Member

jmooring commented Jun 8, 2023

So, we have a lot of related options, and it's not clear to me how some of these interact with each other.

--debug       debug output
--log         enable logging
--logFile     log filepath (if set, logging enabled automatically)
--verbose     verbose output
--verboseLog  verbose logging

And there's #9648.

@bep
Copy link
Member Author

bep commented Jun 8, 2023

So, we have a lot of related options, and it's not clear to me how some of these interact with each other.

I was hoping that you could clarify this situation. I have no clue. The goal of the CLI rewrite was to not break anything, which is why I marked this as a bug... But I have never used file logging myself. Of the flags you list I would probably keep:

--verbose (= log level INFO)
--debug ( = log level DEBUG)

Which tells me that we could probably hide the above and add a new ... --logLevel.

And do logging to stdout only.

@jmooring
Copy link
Member

jmooring commented Jun 8, 2023

I was hoping that you could clarify this situation. I have no clue.

Neither do I. Probably seemed like a good idea at the time.


Assuming --logLevel DEBUG includes both DEBUG and INFO statements, your suggestion works for me.

This reduces the number of flags from 5 to 1. If someone needs a file they can redirect to whatever.

probably hide the above

Or throw deprecation warnings.

@bep
Copy link
Member Author

bep commented Jun 8, 2023

We also have the related --quiet which removes ... everything. But that is also muting non-log print statements (e.g. "Total in ...").

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants