Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebP Exif support #10855

Closed
alexvanderberkel opened this issue Mar 20, 2023 · 10 comments · Fixed by #12651
Closed

WebP Exif support #10855

alexvanderberkel opened this issue Mar 20, 2023 · 10 comments · Fixed by #12651
Labels
Enhancement Outdated
Milestone
v0.129.0

Comments

@alexvanderberkel
Copy link

Currently only JPEG and Tiff are support as file format for reading Exif data from files. I think it would beneficial if also exif data from WebP images could be read within hugo.
@bep bep added this to the v0.113.0 milestone Apr 15, 2023
@wild0ne
Copy link

wild0ne commented Apr 20, 2023

@alexvanderberkel Hey! Could you please provide a user scenario for this enhancement?

@alexvanderberkel
Copy link
Author

Hej. Of course I can. Think about a gallery of images where you display your images. On that you would like to show also the Exif data of an image. This could be just the camera, aperture, exposure time and ISO. WebP does contain all this data similar to jpg.

An example could be this https://github.com/mfg92/hugo-shortcode-gallery

@wild0ne
Copy link

wild0ne commented Apr 22, 2023

Ok, let me look into this and see what I can do

@wild0ne
Copy link

wild0ne commented Apr 22, 2023

/assign

@bep bep modified the milestones: v0.113.0, v0.114.0, v0.115.0 Jun 8, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 5, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@alexvanderberkel
Copy link
Author

Might be it is worth thinking about introducing https://github.com/dsoprea/go-exif if this has not being considered already. The library would allow reading exif data from WebP files if I am not mistaken. dsoprea/go-webp-image-structure@f9047d2

@jmooring
Copy link
Member

See #8586. Maintenance of dsoprea/go-exif has been... sporadic.

@bep
Copy link
Member

bep commented Jan 18, 2024

I started to implement a new image metadata library, but I got a little overwhelmed when I started to look at IPTC. The EXIF part was relatively straight forward, though (including WebP support), so maybe I should pick up that thread and push IPTC for another time/year.

@bep bep modified the milestones: v0.122.0, v0.123.0 Jan 27, 2024
@jbsilva
Copy link

jbsilva commented Jul 6, 2024

I started to implement a new image metadata library, but I got a little overwhelmed when I started to look at IPTC. The EXIF part was relatively straight forward, though (including WebP support), so maybe I should pick up that thread and push IPTC for another time/year.

This would be awesome.
In my case, I'm very interested in reading Exif XPKeywords (UCS-2) or IPTC Keywords. It would work great with your gallerydeluxe.

@bep bep modified the milestones: v0.125.0, v0.129.0 Jul 7, 2024
bep added a commit to bep/hugo that referenced this issue Jul 9, 2024
@bep
Switch EXIF library
24d3dc1 
Closes gohugoio#10855
Closes gohugoio#8586
@bep bep mentioned this issue Jul 9, 2024
Merged
@bep
Copy link
Member

bep commented Jul 9, 2024

FYI: I have started the work to get my "image meta" library over the finish line (as in: Good enough to be used by Hugo).

Nothing to test in the above yet, but soon.

bep added a commit to bep/hugo that referenced this issue Jul 9, 2024
@bep
Switch EXIF library
2c1fca9 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 10, 2024
@bep
Switch EXIF library
74a7b62 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 12, 2024
@bep
Switch EXIF library
1a8a771 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 12, 2024
@bep
Switch EXIF library
d21e7e0 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 12, 2024
@bep
Switch EXIF library
a569d73 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 14, 2024
@bep
Switch EXIF library
05ed5e0 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 18, 2024
@bep
Switch EXIF library
1572e3d 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 19, 2024
@bep
Switch EXIF library
f1442cd 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 19, 2024
@bep
Switch EXIF library
c5222b5 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
edeacc2 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
e46caef 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
1a70371 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
b1cdbec 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
43e7d79 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
b6edcab 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit to bep/hugo that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
d2bfe27 
Closes gohugoio#10855
Closes gohugoio#8586
Closes gohugoio#8996
bep added a commit that referenced this issue Jul 20, 2024
@bep
Switch EXIF library
72ff937 
Closes #10855
Closes #8586
Closes #8996
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.129.0
Development

Successfully merging a pull request may close this issue.

Switch EXIF library bep/hugo
5 participants
@jmooring @bep @jbsilva @alexvanderberkel @wild0ne