Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'xxx' is not a function err #4977

Merged
merged 1 commit into from
May 17, 2018

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented May 16, 2018

Because new version of rxjs you need import each function manually, update code to avoid related errors.
Issues #4923 #4904 are caused by this problem.

@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage increased (+0.05%) to 64.566% when pulling a8025d2 on ninjadq:fix_observable_issues into 3917512 on vmware:master.

@ninjadq ninjadq force-pushed the fix_observable_issues branch from 8ec18ea to 7e91feb Compare May 16, 2018 03:38
Because new version of rxjs you need import function manually, update code to avoid related errors.
Issues goharbor#4923 goharbor#4904 are caused by this problem.
@ninjadq ninjadq force-pushed the fix_observable_issues branch from 7e91feb to a8025d2 Compare May 16, 2018 06:00
Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou steven-zou merged commit 6a7ba46 into goharbor:master May 17, 2018
@ninjadq ninjadq deleted the fix_observable_issues branch April 16, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants