Fix legacy issues that html and css file are written on ts file. #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjadq
force-pushed
the
mv_string_to_html_n_css
branch
5 times, most recently
from
1056127 to
cabed8b
Compare
steven-zou
reviewed
May 10, 2018
| @@ -19,7 +19,7 @@ import { Configuration } from 'harbor-ui'; | |||
| @Component({ | |||
| selector: 'config-email', | |||
| templateUrl: "config-email.component.html", | |||
| styleUrls: ['../config.component.css'] | |||
| styleUrls: ['../config.component.scss'] | |||
| @@ -41,7 +41,7 @@ import {BatchInfo, BathInfoChanges} from "../../shared/confirmation-dialog/confi | |||
|
|
|||
| @Component({ | |||
| templateUrl: "member.component.html", | |||
| styleUrls: ["./member.component.css"], | |||
| styleUrls: ["./member.component.scss"], | |||
There was a problem hiding this comment.
WHY one with './' another without './'
| template: SYSTEM_SETTINGS_HTML, | ||
| styles: [REGISTRY_CONFIG_STYLES] | ||
| templateUrl: './system-settings.component.html', | ||
| styleUrls: ['../registry-config.component.scss'] |
| template: REPLICATION_CONFIG_HTML, | ||
| styles: [REGISTRY_CONFIG_STYLES] | ||
| templateUrl: './replication-config.component.html', | ||
| styles: ['../registry-config.component.scss'] |
Currently, our html and css files are written as string on .ts file. This pr is to solve the legacy issue.
ninjadq
force-pushed
the
mv_string_to_html_n_css
branch
from
cabed8b to
282a63f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our html and css files are written as string on .ts file. This pr is to solve the legacy issue.