Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ng-packagr to packaging harbor-ui npm repo #4875

Merged
merged 1 commit into from
May 9, 2018
Merged

Add ng-packagr to packaging harbor-ui npm repo #4875

merged 1 commit into from
May 9, 2018
+104 −564

Conversation

ninjadq
Copy link
Member

@ninjadq ninjadq commented May 7, 2018

Using ng-packagr to build and publish npm repo

@ninjadq ninjadq requested a review from steven-zou May 7, 2018 12:32
@ninjadq ninjadq force-pushed the ng_packagr_integration branch 2 times, most recently from b17c4f6 to b0bc7c6 Compare May 7, 2018 12:50
@coveralls
Copy link

coveralls commented May 7, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.006%) to 64.509% when pulling 2ef1a92 on ninjadq:ng_packagr_integration into df055e3 on vmware:master.

@ninjadq ninjadq force-pushed the ng_packagr_integration branch 4 times, most recently from f345fc3 to 2ef1a92 Compare May 9, 2018 02:58
@ninjadq
Add ng-packagr to packaging harbor-ui npm repo
2ef1a92 
Using ng-packagr to build and publish npm repo
steven-zou
steven-zou approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou steven-zou merged commit 92782ab into goharbor:master May 9, 2018
@ninjadq ninjadq deleted the ng_packagr_integration branch April 16, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-zou steven-zou steven-zou approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ninjadq @coveralls @steven-zou @vmwclabot