Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ldap-search-password support to Helm Contrib #4827

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Add ldap-search-password support to Helm Contrib #4827

merged 5 commits into from
Apr 30, 2018

Conversation

ArcticSnowman
Copy link

@ArcticSnowman ArcticSnowman commented Apr 30, 2018

New PR to replace #4619 - to clean up all the commits from the rebase.

@ArcticSnowman
Copy link
Author

Pinging @jessehu and @paulczar

@ArcticSnowman
Copy link
Author

What does vmwclabot Pending — CLA is signed and under review, needs legal approval mean?

@jessehu
Copy link
Contributor

jessehu commented Apr 30, 2018

Have you signed the CLA in other PR and got VMware legal approval?

@ArcticSnowman
Copy link
Author

I signed the CLA and put in our legal rep to sign it off... I believe he has done that.. Not seen any approval from VMWare..

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 64.406% when pulling 8f53038 on GrantStreetGroup:helm-update into ee6e85f on vmware:master.

@jessehu jessehu merged commit 2229217 into goharbor:master Apr 30, 2018
@ArcticSnowman ArcticSnowman deleted the helm-update branch April 30, 2018 14:53
@vmwclabot
Copy link

@ArcticSnowman, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

@vmwclabot
Copy link

@ArcticSnowman, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

@vmwclabot
Copy link

@ArcticSnowman, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants