Skip to content

[CHERRY-PICK] fix(gc): redact redis_url_reg from GC extra attrs (#23134)#23141

Merged
chlins merged 1 commit intogoharbor:release-2.15.0from
chlins:release-2.15/fix/gc-redis-info
Apr 20, 2026
Merged

[CHERRY-PICK] fix(gc): redact redis_url_reg from GC extra attrs (#23134)#23141
chlins merged 1 commit intogoharbor:release-2.15.0from
chlins:release-2.15/fix/gc-redis-info

Conversation

@chlins
Copy link
Copy Markdown
Member

@chlins chlins commented Apr 17, 2026

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Cherry pick of #23134

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins requested a review from a team as a code owner April 17, 2026 07:17
@chlins chlins enabled auto-merge (squash) April 17, 2026 07:17
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.15.0@72206bf). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/server/v2.0/handler/model/gc.go 0.00% 8 Missing ⚠️
src/server/v2.0/handler/gc.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.15.0   #23141   +/-   ##
=================================================
  Coverage                  ?   65.98%           
=================================================
  Files                     ?     1074           
  Lines                     ?   116665           
  Branches                  ?     2941           
=================================================
  Hits                      ?    76986           
  Misses                    ?    35405           
  Partials                  ?     4274           
Flag Coverage Δ
unittests 65.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/server/v2.0/handler/gc.go 2.33% <0.00%> (ø)
src/server/v2.0/handler/model/gc.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit af6888c into goharbor:release-2.15.0 Apr 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants