fix(scan): use created time from annotations in accessory art#23113
Merged
chlins merged 1 commit intogoharbor:mainfrom Apr 20, 2026
Merged
fix(scan): use created time from annotations in accessory art#23113chlins merged 1 commit intogoharbor:mainfrom
chlins merged 1 commit intogoharbor:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23113 +/- ##
=======================================
Coverage 66.01% 66.01%
=======================================
Files 1074 1074
Lines 116697 116702 +5
Branches 2941 2941
=======================================
+ Hits 77032 77045 +13
+ Misses 35392 35383 -9
- Partials 4273 4274 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: chlins <chlins.zhang@gmail.com>
20ea496 to
7d25c8c
Compare
stonezdj
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
This pull request introduces an improvement to the handling of artifact creation times in the
GenAccessoryArtfunction within thepackage scan. The function now parses acreatedtimestamp from the provided annotations and uses it to set the artifact's creation time, allowing for more accurate metadata.Enhancement to artifact creation metadata:
src/pkg/scan/util.go: Updated theGenAccessoryArtfunction to parse thecreatedvalue fromaccAnnotationsand set it as the artifact's creation time, improving accuracy of artifact metadata.src/pkg/scan/util.go: Added import of thetimepackage to support parsing RFC3339 timestamps.Issue being fixed
Fixes #23112
Please indicate you've done the following: