fix: handle Redis errors correctly in connection limiter #22679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Jamdade <tushar@DESKTOP-0D1FVJR.localdomain>
Author
|
Hi @bupd, |
Tusharjamdade
changed the title
stonezdj
approved these changes
Dec 29, 2025
stonezdj
reviewed
Dec 29, 2025
| allowed, err := connection.Limiter.Acquire(ctx, client, key, p.MaxUpstreamConnection()) | ||
| if err != nil { | ||
| // Redis unavailable or script error → do NOT return 429 | ||
| log.Errorf("connection limiter error (blob), skipping rate limit: %v", err) |
Contributor
There was a problem hiding this comment.
Previous logic will return 429, now it should return 500 instead?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22679 +/- ##
==========================================
+ Coverage 45.36% 46.54% +1.17%
==========================================
Files 244 252 +8
Lines 13333 14273 +940
Branches 2719 2931 +212
==========================================
+ Hits 6049 6643 +594
- Misses 6983 7273 +290
- Partials 301 357 +56
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
stonezdj
requested changes
Dec 29, 2025
Contributor
stonezdj
left a comment
stonezdj
left a comment
There was a problem hiding this comment.
Please return 500 when the Acquire return error
Signed-off-by: Tushar Jamdade <tushar@DESKTOP-0D1FVJR.localdomain>
Author
|
Hi @stonezdj, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Fixes incorrect HTTP 429 responses when Redis is unavailable in the connection limiter.
Redis errors are now handled gracefully instead of being treated as rate-limit exhaustion
Issue being fixed
Fixes #22675
Please indicate you've done the following: