-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gc): align the blobs in the artifact trash and useless blobs #20735
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20735 +/- ##
===========================================
+ Coverage 45.36% 66.25% +20.88%
===========================================
Files 244 1045 +801
Lines 13333 113551 +100218
Branches 2719 2845 +126
===========================================
+ Hits 6049 75228 +69179
- Misses 6983 34207 +27224
- Partials 301 4116 +3815
Flags with carried forward coverage won't be shown. Click here to find out more.
|
如果 在删除 artifact 的时候 touch 一下 artifact 对应的 blob 行,将 blob 行 update 更新,会不会更好一些呢?这样在 GC 时,删除的 artifact 整个 image 内容都会保留,而不会像现在一样,只是保留了 manifest 的数据层。 |
aebf178
to
8febfdf
Compare
During the GC mark stage, blobs corresponding to newly deleted artifacts during the query process are removed to ensure the consistency of data in trash and blobs and prevent dirty data from being left behind. Signed-off-by: chlins <chlins.zhang@gmail.com>
8febfdf
to
c947027
Compare
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
During the GC mark stage, blobs corresponding to newly deleted artifacts during the query process are removed to ensure the consistency of data in trash and blobs and prevent dirty data from being left behind.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20711
Please indicate you've done the following: