Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo for About UI #19840

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Fixing typo for About UI #19840

merged 3 commits into from
Jan 15, 2024

Conversation

hasonhai
Copy link
Contributor

Removing double "an" in the About UI

Signed-off-by: Ha, Son Hai <sonhaiha@kpmg.com>
@hasonhai hasonhai requested a review from a team as a code owner January 12, 2024 12:52
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f17d90f) 0.00% compared to head (830a470) 67.54%.

❗ Current head 830a470 differs from pull request most recent head 5c2e635. Consider uploading reports for the commit 5c2e635 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main   #19840       +/-   ##
=========================================
+ Coverage      0   67.54%   +67.54%     
=========================================
  Files         0      991      +991     
  Lines         0   109171   +109171     
  Branches      0     2719     +2719     
=========================================
+ Hits          0    73741    +73741     
- Misses        0    31462    +31462     
- Partials      0     3968     +3968     
Flag Coverage Δ
unittests 67.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 991 files with indirect coverage changes

@linuxfa
Copy link

linuxfa commented Jan 13, 2024

this is a test

@MinerYang MinerYang added the release-note/update Update or Fix label Jan 15, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 15, 2024 14:39
@Vad1mo Vad1mo merged commit 7e0f6cc into goharbor:main Jan 15, 2024
10 checks passed
@OrlinVasilev
Copy link
Member

@hasonhai congrats on your first PR here!!!!!

altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: Ha, Son Hai <sonhaiha@kpmg.com>
Co-authored-by: Ha, Son Hai <sonhaiha@kpmg.com>
Co-authored-by: MinerYang <yminer@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants