Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid links in harbor.yml.tmpl #19786

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

microyahoo
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@microyahoo microyahoo requested a review from a team as a code owner January 3, 2024 08:12
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the release-note/update Update or Fix label Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aefe1bc) 45.27% compared to head (71d4f35) 45.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19786      +/-   ##
==========================================
- Coverage   45.27%   45.25%   -0.02%     
==========================================
  Files         244      244              
  Lines       13332    13332              
  Branches     2719     2719              
==========================================
- Hits         6036     6034       -2     
- Misses       6996     6997       +1     
- Partials      300      301       +1     
Flag Coverage Δ
unittests 45.25% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
@chlins chlins enabled auto-merge (squash) January 4, 2024 06:20
@chlins chlins merged commit 4378c15 into goharbor:main Jan 4, 2024
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants