Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oidc provider name to systeminfo API #19575

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 14, 2023

fixes #13198

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner November 14, 2023 03:23
@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 14, 2023
@stonezdj stonezdj assigned zyyw and unassigned AllForNothing and MinerYang Nov 14, 2023
   fixes goharbor#13198

Signed-off-by: stonezdj <daojunz@vmware.com>
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #19575 (c88c97d) into main (04397fb) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19575      +/-   ##
==========================================
+ Coverage   67.54%   67.55%   +0.01%     
==========================================
  Files         990      990              
  Lines      109035   109055      +20     
  Branches     2719     2719              
==========================================
+ Hits        73650    73677      +27     
+ Misses      31420    31413       -7     
  Partials     3965     3965              
Flag Coverage Δ
unittests 67.55% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/systeminfo/controller.go 64.00% <100.00%> (+3.70%) ⬆️
src/server/v2.0/handler/systeminfo.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 3f6c029 into goharbor:main Nov 15, 2023
12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
fixes goharbor#13198

Signed-off-by: stonezdj <daojunz@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize the text of the OIDC login button
5 participants