Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proposal process with steps and board #18379

Merged
merged 10 commits into from
Apr 7, 2023

Conversation

OrlinVasilev
Copy link
Member

@OrlinVasilev OrlinVasilev commented Mar 20, 2023

Signed-off-by: OrlinVasilev ovasilev@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

OrlinVasilev added 2 commits March 20, 2023 16:20
Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
Signed-off-by: OrlinVasilev <ovasilev@vmware.com>
@OrlinVasilev
Copy link
Member Author

@a-mccarthy can you check the wording please :)

@Vad1mo
Copy link
Member

Vad1mo commented Mar 20, 2023

Develop and propose new features.

  • The following simple step process can be used to submit new features or changes to the existing code.
  • See if your feature is already being worked on. Check both the Issues and the PRs in the main Harbor repository as well as the Community repository.
  • Submit (open PR) with the new proposal in community/proposals/new using this template.
  • The proposal must be labeled as "kind/proposal" once submitted. Check examples here.
  • The proposal can be modified and adapted to meet the requirements from the community and other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the Roadmap.
  • When reviewed and approved, it can be implemented either by the original submitter or by anyone else in the community. Open PRs in the respective repositories with all the necessary code and test changes!
  • Once implemented or during the implementation, the PRs are reviewed by maintainers and contributors, following the currently enabled practices and methods.
  • After merging the new PRs, the proposal must be moved to Community/Proposals and marked as done.
  • You have made Harbor even better, congratulations. Thank you!

sorry a few links got lost.

@OrlinVasilev
Copy link
Member Author

@Vad1mo adopted your input ! Thank you!

@OrlinVasilev
Copy link
Member Author

@KaulAnmol check this out :)

@OrlinVasilev OrlinVasilev changed the title Update proposal process wthh steps and board Update proposal process with steps and board Mar 22, 2023
@OrlinVasilev
Copy link
Member Author

OrlinVasilev commented Mar 24, 2023

Hey Folks can you check that please @wy65701436 @KaulAnmol @holyhope @slushysnowman @MarcelMue @thcdrt thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
OrlinVasilev and others added 4 commits March 24, 2023 14:43
Co-authored-by: Thomas Coudert <couderthomas@gmail.com>
Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>
Co-authored-by: Thomas Coudert <couderthomas@gmail.com>
Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>
Co-authored-by: Thomas Coudert <couderthomas@gmail.com>
Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev OrlinVasilev merged commit 1a8b918 into goharbor:main Apr 7, 2023
@OrlinVasilev OrlinVasilev deleted the update-proposal-process branch April 7, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants