-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Logging): create new JSON logger #18142
Conversation
Signed-off-by: Sébastien GLON <sebastien.glon@ubble.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18142 +/- ##
===========================================
- Coverage 67.39% 44.71% -22.69%
===========================================
Files 984 235 -749
Lines 106990 13089 -93901
Branches 2670 2670
===========================================
- Hits 72110 5853 -66257
+ Misses 30999 6943 -24056
+ Partials 3881 293 -3588
Flags with carried forward coverage won't be shown. Click here to find out more. |
8c8b3bb
to
b4ed5f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs to be mentioned in the docs
@Vad1mo doc issue is created for tracking |
I was expecting a PR 😂 or an issue with a bit more context that me, you or anybody else knows what to do in a week |
Hello guys! @Vad1mo, @OrlinVasilev maybe planning to 2.9? |
@sebglon can you please point me to the docs PR ? thanks |
@IwanSE - not sure yet @wy65701436 @msha01 @Vad1mo ideas maybe we can discuss it on next community meeting https://github.com/goharbor/community/wiki/Harbor-Community-Meetings |
@sebglon would you mind to fix the UI failure? I've marked this as a candidate of v2.10, then we can start review this PR. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
@sebglon are you still up for working on this :) it will be great! |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Add new formatter for JSON format log.
New Env variable to select format type:
LOG_FORMAT
; value isjson
for Jsonf format else we use the default text formatIssue being fixed
Fixes #15820
Please indicate you've done the following: