Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Logging): create new JSON logger #18142

Closed
wants to merge 4 commits into from
Closed

Conversation

sebglon
Copy link

@sebglon sebglon commented Jan 30, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Add new formatter for JSON format log.
New Env variable to select format type: LOG_FORMAT; value is json for Jsonf format else we use the default text format

Issue being fixed

Fixes #15820

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Sébastien GLON <sebastien.glon@ubble.ai>
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de6e517) 67.39% compared to head (cf0514f) 44.71%.
Report is 343 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18142       +/-   ##
===========================================
- Coverage   67.39%   44.71%   -22.69%     
===========================================
  Files         984      235      -749     
  Lines      106990    13089    -93901     
  Branches     2670     2670               
===========================================
- Hits        72110     5853    -66257     
+ Misses      30999     6943    -24056     
+ Partials     3881      293     -3588     
Flag Coverage Δ
unittests 44.71% <ø> (-22.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

@Vad1mo Vad1mo added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Mar 5, 2023
@sebglon sebglon force-pushed the log-json branch 2 times, most recently from 8c8b3bb to b4ed5f3 Compare March 6, 2023 08:51
@Vad1mo Vad1mo added the doc-impact Engineering issues that will require a change in user docs label Apr 12, 2023
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be mentioned in the docs

@sebglon
Copy link
Author

sebglon commented Apr 14, 2023

@Vad1mo doc issue is created for tracking

@Vad1mo
Copy link
Member

Vad1mo commented Apr 14, 2023

I was expecting a PR 😂 or an issue with a bit more context that me, you or anybody else knows what to do in a week

@IwanSE
Copy link

IwanSE commented Jun 6, 2023

Hello guys!

@Vad1mo, @OrlinVasilev maybe planning to 2.9?

@OrlinVasilev
Copy link
Member

@sebglon can you please point me to the docs PR ? thanks

@OrlinVasilev
Copy link
Member

@IwanSE - not sure yet @wy65701436 @msha01 @Vad1mo ideas maybe we can discuss it on next community meeting https://github.com/goharbor/community/wiki/Harbor-Community-Meetings

@wy65701436
Copy link
Contributor

wy65701436 commented Aug 25, 2023

@sebglon would you mind to fix the UI failure? I've marked this as a candidate of v2.10, then we can start review this PR.

@wy65701436 wy65701436 assigned chlins and unassigned AllForNothing and MinerYang Aug 25, 2023
@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Oct 24, 2023
@OrlinVasilev
Copy link
Member

@sebglon are you still up for working on this :) it will be great!

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Feb 17, 2024
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate/2.11.0 doc-impact Engineering issues that will require a change in user docs release-note/enhancement Label to mark PR to be added under release notes as enhancement Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json logs
9 participants