Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Add IP and agent in trace for failed login #16447

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Mar 2, 2022

Fixes #16423

Signed-off-by: stonezdj stonezdj@gmail.com

   Fixes goharbor#16423

Signed-off-by: stonezdj <stonezdj@gmail.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #16447 (9d5dc01) into release-2.4.0 (a539346) will increase coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.4.0   #16447      +/-   ##
=================================================
+ Coverage          66.80%   66.84%   +0.04%     
=================================================
  Files                934      934              
  Lines              77776    77789      +13     
  Branches            2287     2287              
=================================================
+ Hits               51955    51998      +43     
+ Misses             21810    21783      -27     
+ Partials            4011     4008       -3     
Flag Coverage Δ
unittests 66.84% <92.85%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/middleware/security/basic_auth.go 71.42% <92.85%> (+24.76%) ⬆️
src/jobservice/worker/cworker/c_worker.go 68.42% <0.00%> (+1.91%) ⬆️
...es/vulnerability/vulnerability-config.component.ts 55.55% <0.00%> (+4.76%) ⬆️
src/jobservice/runner/redis.go 67.82% <0.00%> (+5.21%) ⬆️
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 75.00% <0.00%> (+25.00%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 60.86% <0.00%> (+52.17%) ⬆️

@stonezdj stonezdj merged commit 13d2c9a into goharbor:release-2.4.0 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants