feat: add failure-tolerance for gc #16094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16094 +/- ##
==========================================
- Coverage 66.93% 66.91% -0.02%
==========================================
Files 944 944
Lines 78447 78467 +20
Branches 2304 2304
==========================================
+ Hits 52508 52509 +1
- Misses 21891 21907 +16
- Partials 4048 4051 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zyyw
force-pushed
the
gc-failure-tolerance
branch
from
c1ff6a4
to
0c3de37
Compare
zyyw
force-pushed
the
gc-failure-tolerance
branch
from
0c3de37
to
b2fe7f3
Compare
zyyw
force-pushed
the
gc-failure-tolerance
branch
3 times, most recently
from
38cd60f
to
f390c38
Compare
wy65701436
reviewed
Jan 10, 2022
| @@ -265,9 +268,11 @@ func (gc *GarbageCollector) sweep(ctx job.Context) error { | |||
| if err := ignoreNotFound(func() error { | |||
| return gc.markDeleteFailed(ctx, blob) | |||
| }); err != nil { | |||
| gc.logger.Errorf("failed to call gc.markDeleteFailed() after v2DeleteManifest() error out: %s, %v", blob.Digest, err) | |||
There was a problem hiding this comment.
the error was recorded in the markDeleteFailed() method, dup here.
wy65701436
reviewed
Jan 10, 2022
| @@ -255,6 +257,7 @@ func (gc *GarbageCollector) sweep(ctx job.Context) error { | |||
| } | |||
|
|
|||
| // remove tags and revisions of a manifest | |||
| skippedBlobs := map[string]interface{}{} | |||
There was a problem hiding this comment.
bool varaible is enough.
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
zyyw
force-pushed
the
gc-failure-tolerance
branch
from
f390c38
to
d2ae016
Compare
heww
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15469
Closes: #15822
Signed-off-by: Shengwen Yu yshengwen@vmware.com