Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Created confirmation for elevating user to admin #70

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

Althaf66
Copy link
Collaborator

@amands98 ,

Completed the TODO in the elevate command.

Created confirmation for elevating user to admin.

@Althaf66 Althaf66 changed the title created confirmation for elevating user to admin feat: Created confirmation for elevating user to admin May 23, 2024
Signed-off-by: Althaf66 <althafasharaf02@gmail.com>
@Althaf66 Althaf66 reopened this Jun 8, 2024
Signed-off-by: Althaf66 <althafasharaf02@gmail.com>
Signed-off-by: Althaf66 <althafasharaf02@gmail.com>
Copy link
Collaborator

@amands98 amands98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run lint the file using make command or gofmt -s -w .

Signed-off-by: Althaf66 <althafasharaf02@gmail.com>
@Althaf66
Copy link
Collaborator Author

Althaf66 commented Jun 8, 2024

make changes,
ready for review @amands98

Copy link
Collaborator

@amands98 amands98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Vad1mo Vad1mo merged commit b164280 into goharbor:main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants