Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: fix the goreleaser release cycle & Dependabot #20

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

amands98
Copy link
Collaborator

@amands98 amands98 commented Feb 15, 2024

This PR fixes the failing workflow

This PR suggests tagging v0.1.0-beta.1 and proceeding with the release.

Updated goreleaser configuration, @Vad1mo . Add GH_TOKEN secret with repo scope, write:packages.
Also I included a dependabot, to automate dependency updates.

After merging, let's release the packages on Homebrew, Winget, Nix, and Snap.

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
@JaeAeich
Copy link
Contributor

JaeAeich commented Feb 16, 2024

It would also make a lot of sense IMO to make a install script that Unix users can pipe into bash/zsh to make the release form source and configure the binaries into the right directories, something like ~/usr/local/bin .

@bishal7679
Copy link
Contributor

It would also make a lot of sense IMO to make a install script that Unix users can pipe into bash/zsh to make the release form source and configure the binaries into the right directories, something like ~/usr/local/bin .

Yes! #18 doing the same thing but need to clone the repository.

@Vad1mo
Copy link
Member

Vad1mo commented Feb 17, 2024

I need to check that @OrlinVasilev, I don't have the owner permission set for the org to request such a token
.
.

@OrlinVasilev
Copy link
Member

will take care of that :)

@OrlinVasilev OrlinVasilev self-requested a review February 25, 2024 07:34
@OrlinVasilev
Copy link
Member

OrlinVasilev commented Feb 26, 2024

image not sure why are you renaming the token to GH_TOKEN ? what's the idea behind it that comes by default

@OrlinVasilev
Copy link
Member

@bishal7679
Copy link
Contributor

image not sure why are you renaming the token to GH_TOKEN ? what's the idea behind it that comes by default

It automatically fetches if we specify as GITHUB_TOKEN otherwise for different naming we need to set that as repo secret var.

@OrlinVasilev
Copy link
Member

@bishal7679 exactly :) we have it working with the default token no need for additional one IMO ?

@amands98
Copy link
Collaborator Author

amands98 commented Feb 26, 2024

@Vad1mo
Copy link
Member

Vad1mo commented Feb 27, 2024

just following the naming rules. https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#naming-your-secrets

image

Makes sense if you are creating your own secret, however we are reusing the exising one here.

@Vad1mo
Copy link
Member

Vad1mo commented Mar 1, 2024

@amands98 Can you address my comment?

@amands98
Copy link
Collaborator Author

amands98 commented Mar 1, 2024

Sure, let's use the default GITHUB_TOKEN with the required scopes (repo, write:packages). After that, we can merge and re-run the workflow to ensure the harbor-cli binaries are generated effectively.

@Vad1mo Vad1mo merged commit 869986a into goharbor:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants