Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIGs for Docs and Community Engagement #180

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

jonasrosland
Copy link
Contributor

We've previously discussed updating the governance doc to include more responsibilities under the "Maintainers" title.

After discussion with @caniszczyk the recommendation is to create something like "Doc Maintainers" or "SIG Docs" or "SIG Community Management" within our MAINTAINERS.md, that way the maintainers description can keep as is and we have more flexibility when we want to add more responsibility to awesome contributors.

This PR adds SIG Docs and SIG Community Engagement, with respective owners for each SIG.

Signed-off-by: Jonas Rosland jrosland@vmware.com

Signed-off-by: Jonas Rosland <jrosland@vmware.com>
@xaleeks
Copy link
Contributor

xaleeks commented Nov 18, 2021

I like 'SIG Community Management'

@Vad1mo
Copy link
Member

Vad1mo commented Nov 22, 2021

@jonasrosland I section languages for translation would be a good point as well.

Vad1mo
Vad1mo previously approved these changes Dec 15, 2021
yanji09
yanji09 previously approved these changes Dec 20, 2021
@OrlinVasilev
Copy link
Member

@goharbor/all-maintainers can you please review and vote!

@tianon
Copy link
Member

tianon commented Feb 5, 2022

I think this seems fine, but I wonder about @xaleeks's suggestion -- "SIG Community Engagement" vs "SIG Community Management" doesn't seem very different to me, but maybe Alex can elaborate on why the latter should be preferred? 🙏

@OrlinVasilev
Copy link
Member

I think it's just wording, in Contour we named it SIG Community and overall that sounds good :)
I aslo like the short form SIG Community - which may include Community + Docs + Site + Events + Webinars etc...

@OrlinVasilev OrlinVasilev self-assigned this Feb 5, 2022
MAINTAINERS.md Outdated Show resolved Hide resolved
Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets merge :)

@OrlinVasilev
Copy link
Member

@tianon @Vad1mo @jonasrosland @steven-zou please review and approve so we can finish this :)

@OrlinVasilev OrlinVasilev added the enhancement New feature or request label Feb 22, 2022
@OrlinVasilev
Copy link
Member

@tianon - are you ok with the proposed changes ? if So please approve :)

@OrlinVasilev OrlinVasilev merged commit 29b42cd into goharbor:main Feb 23, 2022
@OrlinVasilev
Copy link
Member

Merged!!! Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants