Web editor

[unknwon]

Web editor for repository files are now in public beta in master branch and demo site (https://try.gogs.io), but not yet fully done.

Todos/issues:

• Web editor should use proper author name and email
• Improve code quality
• Mirror repository should not allow edit
• Web editor changes line endings to DOS
• Cannot create new file in subdirectory
• Re-enable upload files

I'll maintain this list based on feedback in comments.

Besides, to keep this thread clean and focus on implementation, there are some rules of comment in this thread; violate to those rules will result in deletion of your comment without warning:

1. Do not comment unless you have a bug report with reproduce steps on demo site (https://try.gogs.io)
2. Do not post duplicated or irrelavent problems
3. Use reactions

[richmahn]

@unknwon I don't understand the mirror repositories should not allow edit item. Like Github, even a repo that you can't edit still has an edit icon and has you fork it if you can't edit. Or are you saying if someone mirrors my repo, currently I can edit their repo but shouldn't be able to? How to reproduce what you saw?

[unknwon]

@richmahn You simply can't push changes to a mirror repository in Gogs, this is by Gogs's definition. You can also fork but can't send pull request.

[joubertredrat]

This is results from my first test, was tested on Firefox, Chrome, Opera and Vivaldi. Fortunately, IE doesn't work on Linux :)

• If I edit js, json, css, php files, tabulation doesn't work fine, tab work fine, but shift + tab not.
• If I edit txt files, tab add more tabulation normally, but shift + tab remove all tabulation one time, and the correct was to remove the tabulation one by one.
• On md files, both tab and shift + tab works fine.
• I think that is good to ? tooltip explain too that if you change name on input when you edit, Gogs will rename file.
• Toggle side by side is amazing, nice option.
• Gogs doesn't allow me edit photo files, this is correct.

I will continue testing to see if I have more impressions.

[joubertredrat]

@joubertredrat tested on demo site with Chrome and shift + tab works as expected.

@unknwon You edited md files, text files or another language files? I tested here again with Chrome on both Linux and Windows

• https://try.gogs.io/redrat/ajaxtable/src/master/js/ajaxtable.js = tab work, shift + tab no
• https://try.gogs.io/redrat/ajaxtable/src/master/LICENSE = tab work, shift + tab no (remove all tabulation one time).
• https://try.gogs.io/redrat/ajaxtable/src/master/README.md = tab work, shift + tab work

I will view here If I can provide a small video with this issue.

[unknwon]

@joubertredrat yes, all works, but indeed for code file shift + tab sometimes delete more than it should. But I don't see any code handles tab in Gogs codebase, so I guess it is upstream bug of CodeMirror maybe.

[joubertredrat]

@unknwon Ok, I will test here to see if I can reproduce this issue directly on CodeMirror

[fontenele]

Testing in firefox/linux/debian:

• Creating txt files: OK
• Editing txt files: OK
• Creating php files: OK but indentation is using 2 spaces, normally we use 4 spaces in PHP
• Previewing php files: indentation is confused on preview, but when editing this is OK
• Editing php files: when i go to preview changes without make any changes, it shows me i changed all the file on the diff preview.
• Creating js files: OK
• Editing js files: OK
• Previewing js files: OK
• Creating json files: OK
• Editing json files: OK
• Previewing json files: OK
• ALL FILES EXTENCIONS I edit, without have any change i click in preview then show me as i have changed all the file.

Continue testing...

[unknwon]

Line endings can be different which cause unnecessary diff.

(please continue edit same comment, otherwise will be deleted)

[joubertredrat]

codemirror/codemirror5#4177
[edit]
codemirror/codemirror5#4177 (comment)

[joubertredrat]

@unknwon for shift + tab, is possible to remap keys, on link below have more about this.

https://github.com/codemirror/CodeMirror/blob/master/keymap/sublime.js#L95
You can test this on https://codemirror.net/demo/sublime.html

About indent, have one param on configuration called indentUnit and default is 2, I think that change to 4 solve problem and change indentWithTabs to false for indent with spaces, not tabulations.

[andreynering]

@joubertredrat I played a little with these configs on #3512