Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated customtype fields generate slices w/o pointer to the custom type #478

Open
maros7 opened this issue Sep 7, 2018 · 1 comment
Open

Comments

@maros7
Copy link

maros7 commented Sep 7, 2018

As I mentioned in #477, a Protobuf message containing a repeated field with the customtype option set does not generate a slice of pointers.

Another observation related to customtype is that it doesn't generate a slice of pointers for repeated customtype fields. repeated common.BigDecimal repeated_big_decimal_value = 37 [(gogoproto.customtype) = "go-decimal/pbdecimal.Decimal"]; generates RepeatedBigDecimalValue []go_decimal_pbdecimal.Decimal. I expected RepeatedBigDecimalValue []*go_decimal_pbdecimal.Decimal But I can open a separate issue for this matter.

jmarais added a commit to jmarais/protobuf that referenced this issue Sep 10, 2018
jmarais added a commit that referenced this issue Sep 14, 2018
* added issue link to customtype warnings and issue list

* added issue #478 to the customtype warning and issue list
@Nagaraj007
Copy link

Nagaraj007 commented Oct 16, 2018

I am also facing same issue, Any updates on creating the slice pointer using customtype, i have created
#496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants