-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trace): add trace example for custom trace client and provider #3847
Conversation
@houseme codes conflict |
@houseme 我总感觉没有封装初始化 |
@houseme I always feel that there is no need to encapsulate and initialize |
或许把这一块的代码移到 |
Maybe move this piece of code to the |
嗯,我觉得这样好。另外咱们现有组件完善下注释,说明下如果自定义的初始化参考哪里。 |
Well, I think that's good. In addition, we will add comments to our existing components to explain where to refer to for customized initialization. |
改完了,看看需要改进一下注释不 |
After the modification, let’s see if the comments need to be improved. |
个人感觉这样挺好的,可以在 |
改了,也加上注释说明 |
feat(trace): add trace for Custom trace client and provider
#3171 #3201 #3834