Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parameters #32

Merged
merged 4 commits into from
Jun 7, 2020
Merged

Support parameters #32

merged 4 commits into from
Jun 7, 2020

Conversation

abahmed
Copy link
Member

@abahmed abahmed commented Jun 5, 2020

Fixes #15

Changes proposed in this pull request:

  • Support parameters

@abahmed abahmed requested a review from muhammednagy June 5, 2020 17:30
@abahmed abahmed added the enhancement New feature or request label Jun 5, 2020
@abahmed abahmed added this to the v1 milestone Jun 5, 2020
router.go Show resolved Hide resolved
@abahmed abahmed requested a review from muhammednagy June 5, 2020 21:41
@abahmed abahmed added enhancement New feature or request and removed enhancement New feature or request labels Jun 5, 2020
muhammednagy
muhammednagy previously approved these changes Jun 6, 2020
@muhammednagy
Copy link
Member

Might be a good idea to also update readme in this PR.

@muhammednagy muhammednagy added enhancement New feature or request and removed enhancement New feature or request labels Jun 7, 2020
@muhammednagy muhammednagy merged commit 3e78feb into master Jun 7, 2020
@abahmed abahmed mentioned this pull request Jun 7, 2020
@abahmed abahmed deleted the support-parameters branch June 10, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parameters in paths
2 participants