Fix issue caused by calling F_SETLKW instead of F_SETLK #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Helflym I could probably use your 👀 on this one too since it's AIX. |
|
It looks good to me. I'm not sure there was any reason to use However, if you want a unit test, separate processes might be mandatory. Fcntl locks are based on "processes" while Flock locks are based on file descriptors. Thus, as goroutines are like threads, it's not a surprise that you can't reproduce it. |
theckman
approved these changes
Mar 11, 2021
|
@theckman What is the next step in getting this PR merged? I have been using it in production for a few months now and have not run into any issues. |
|
@jwatson-gcu I will be going through everything on this repo this weekend. You should see a new release then. Sorry for the delay. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Fix an issue where the AIX implementation uses F_SETLKW instead of F_SETLK for
TryLock(). This causesTryLock()to wait indefinitely for a lock instead of returning with failure. See fcntl() DocumentationI could not figure a way to reproduce this issue with a Unit test. New go-routine did not trigger it, and spawning a separate process became messy real quick. I tested by hand both
Lock()andTryLock()variants between two separate processes and it worked as expected.Unit tests continue run pass successfully under AIX.