Skip to content

Build broken due to Redis library update from 9.7 to 9.8 #1697

Closed
@sorennielsen

Description

@sorennielsen

Describe the bug
mock_datasources.go is using code from Redis that has been removed and refactored.

To Reproduce
Steps to reproduce the behavior, if applicable:

  1. The code is

In project that uses GoFr (or directly in GoFr's main branch)

go get -u
go build

In go get -u output this is seen:

go: upgraded github.com/redis/go-redis/v9 v9.7.3 => v9.8.0

And this breaks the build as shown below.

  1. The error from go build is
# gofr.dev/pkg/gofr/container
container/mock_datasources.go:6010:112: undefined: redis.TFCallOptions
container/mock_datasources.go:6024:107: undefined: redis.TFCallOptions
container/mock_datasources.go:6066:75: undefined: redis.TFunctionListOptions
container/mock_datasources.go:6094:87: undefined: redis.TFunctionLoadOptions
container/mock_container.go:68:20: cannot use redisMock (variable of type *MockRedis) as Redis value in assignment: *MockRedis does not implement Redis (missing method ACLCat)

Expected behavior

No build errors

Environments (please complete the following information):

  • OS: Linux
  • gofr version v1.38.0
  • go version 1.24

More description
https://github.com/redis/go-redis has released version 9.8 with breaking changes.
As goFr is depending on v9 it will select 9.8 instead of 9.7 and fail to build.

The removed code used to be in gears_commands.go which has been completely removed in v9.8

Metadata

Metadata

Assignees

Labels

triageThe issue needs triaging.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions