-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
📚 docs: Fix example in whats_new.md #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 docs: Fix example in whats_new.md #3949
Conversation
Correct the custom context example to use fiber.DefaultCtx and fiber.NewDefaultCtx instead of fiber.Ctx and fiber.NewCtx
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated documentation examples to use Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @omer-cengel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and rectifies an inaccuracy within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an example for using custom contexts in the whats_new.md documentation. The changes replace incorrect types and function calls with the correct ones. My review includes a suggestion to further improve the example by making it more complete and demonstrating the usage of the custom context, which would enhance its value for developers.
|
@omer-cengel Markdownlint failure is unrelated, but can you fix that here too. Thanks! |
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
This PR fixes the incorrect custom context example in the
whats_new.mddocumentation. The example was usingfiber.Ctxandfiber.NewCtx()which are incorrect - the proper types arefiber.DefaultCtxandfiber.NewDefaultCtx()for embedding in custom context structs.Fixes #3948
Changes introduced
/docs/whats_new.mdto use the proper types (fiber.DefaultCtx,fiber.CustomCtx, andfiber.NewDefaultCtx)Type of change
Checklist
/docs/directory for Fiber's documentation.Commit formatting
Used 📚 Doc: prefix for documentation changes