Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add Logger interface and fiberlog #2499

Merged
merged 10 commits into from
Jun 26, 2023
Merged

🚀 Add Logger interface and fiberlog #2499

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
336bc63
add log for fiber
Skyenought Jun 10, 2023
2bdbb37
replace log in fiber
Skyenought Jun 10, 2023
c3171be
add Log use to adapt for log libraries
Skyenought Jun 12, 2023
bd3da60
Update app.go
Skyenought Jun 15, 2023
7c2af59
wip: add log docs
Skyenought Jun 15, 2023
086ef59
add WithLogger use to print key and value
Skyenought Jun 17, 2023
8d26e83
remove CtxLogger and add WithContext use to bind Context
Skyenought Jun 18, 2023
6d129be
fix errcheck
Skyenought Jun 18, 2023
4039a7b
fix errcheck
Skyenought Jun 18, 2023
4e5e237
update log.md
Skyenought Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix errcheck
  • Loading branch information
@Skyenought
Skyenought committed Jun 19, 2023
commit 6d129befb477d7165c4d033bc7aa1e061bfd0bad
21 changes: 10 additions & 11 deletions log/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//nolint:errcheck // we don't care about the error here
package log

import (
Expand Down Expand Up @@ -28,10 +27,10 @@ func (l *defaultLogger) privateLog(lv Level, fmtArgs []interface{}) {
}
level := lv.toString()
buf := bytebufferpool.Get()
_, _ = buf.WriteString(level)
buf.WriteString(fmt.Sprint(fmtArgs...))
_, _ = buf.WriteString(level) //nolint:errcheck // It is fine to ignore the error
_, _ = buf.WriteString(fmt.Sprint(fmtArgs...)) //nolint:errcheck // It is fine to ignore the error

_ = l.stdlog.Output(l.depth, buf.String())
_ = l.stdlog.Output(l.depth, buf.String()) //nolint:errcheck // It is fine to ignore the error
buf.Reset()
bytebufferpool.Put(buf)
if lv == LevelFatal {
Expand All @@ -47,14 +46,14 @@ func (l *defaultLogger) privateLogf(lv Level, format string, fmtArgs []interface
}
level := lv.toString()
buf := bytebufferpool.Get()
_, _ = buf.WriteString(level)
_, _ = buf.WriteString(level) //nolint:errcheck // It is fine to ignore the error

if len(fmtArgs) > 0 {
_, _ = fmt.Fprintf(buf, format, fmtArgs...)
_, _ = fmt.Fprintf(buf, format, fmtArgs...) //nolint:errcheck // It is fine to ignore the error
} else {
_, _ = fmt.Fprint(buf, fmtArgs...)
_, _ = fmt.Fprint(buf, fmtArgs...) //nolint:errcheck // It is fine to ignore the error
}
_ = l.stdlog.Output(l.depth, buf.String())
_ = l.stdlog.Output(l.depth, buf.String()) //nolint:errcheck // It is fine to ignore the error
buf.Reset()
bytebufferpool.Put(buf)
if lv == LevelFatal {
Expand All @@ -70,11 +69,11 @@ func (l *defaultLogger) privateLogw(lv Level, format string, keysAndValues []int
}
level := lv.toString()
buf := bytebufferpool.Get()
_, _ = buf.WriteString(level) //nolint:errcheck
_, _ = buf.WriteString(level) //nolint:errcheck // It is fine to ignore the error

// Write format privateLog buffer
if format != "" {
_, _ = buf.WriteString(format) //nolint:errcheck
_, _ = buf.WriteString(format) //nolint:errcheck // It is fine to ignore the error
}
var once sync.Once
isFirst := true
Expand All @@ -96,7 +95,7 @@ func (l *defaultLogger) privateLogw(lv Level, format string, keysAndValues []int
}
}

_ = l.stdlog.Output(l.depth, buf.String())
_ = l.stdlog.Output(l.depth, buf.String()) //nolint:errcheck // It is fine to ignore the error
buf.Reset()
bytebufferpool.Put(buf)
if lv == LevelFatal {
Expand Down