Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Style: adjusted lines according go-lint #1137

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

sotanodroid
Copy link
Contributor

Please provide enough information so that others can review your pull request:

Updating some lines so them could respect go-lint style. No changes in functionality was made

Explain the details for making this change. What existing problem does the pull request solve?

Replaced explicit comparison to "true" and "false" statements where they was unnecessary.
Replaced unnecessary Sprintf func when obj have String method

Commit formatting

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@welcome
Copy link

welcome bot commented Jan 26, 2021

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@sotanodroid sotanodroid changed the title 🎨 Style: Respected pattern Golint 🎨 Style: adjusted lines according go-lint Jan 26, 2021
@ReneWerner87
Copy link
Member

thanks for the contribution \m/

Copy link
Member

@renanbastos93 renanbastos93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, you made a good job.
Thanks a lot

@Fenny Fenny merged commit cf23dcc into gofiber:master Jan 31, 2021
@welcome
Copy link

welcome bot commented Jan 31, 2021

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants