Skip to content

🐛 [Bug]: Enable go-require for testify-lint #2891

Closed
@gaby

Description

@gaby

Bug Description

The latest testify release added a notice against using require inside a goroutine. This is something covered by testify-lint through the go-require rule which is enabled by default. This rule was disabled during golangci-lint upgrade in #2842

The following tests are failing:

--- FAIL: Test_Ctx_BodyStreamWriter (0.00s)
--- FAIL: Test_Client_Agent_Dest (0.00s)
    --- FAIL: Test_Client_Agent_Dest/small_dest (0.00s)
    --- FAIL: Test_Client_Agent_Dest/enough_dest (0.02s)
--- FAIL: Test_App_New_Test_Parallel (0.00s)
--- FAIL: Test_Client_UserAgent (0.00s)
--- FAIL: Test_App_ReadTimeout (0.57s)
--- FAIL: Test_App_BadRequest (0.58s)
--- FAIL: Test_App_Shutdown (0.00s)
--- FAIL: Test_App_SmallReadBuffer (0.59s)
--- FAIL: Test_Client_Agent_TLS (2.87s)
--- FAIL: Test_App_ShutdownWithContext (3.01s)
--- FAIL: Test_App_ShutdownWithTimeout (3.02s)
--- FAIL: FuzzUtilsGetOffer (0.00s)
FAIL
FAIL	github.com/gofiber/fiber/v3	13.404s
--- FAIL: Test_Proxy_Do_WithRealURL (1.00s)
FAIL
FAIL	github.com/gofiber/fiber/v3/middleware/proxy	8.126s
FAIL

Partly fixed by #2874
Testify Notice: stretchr/testify#1392

How to Reproduce

N/A

Expected Behavior

N/A

Fiber Version

v3.0.0

Code Snippet (optional)

No response

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my problem prior to opening this one.
  • I understand that improperly formatted bug reports may be closed without explanation.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions