Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support configuring log levels and reqHeaders support #359

Merged
merged 2 commits into from
Dec 11, 2022
Merged

support configuring log levels and reqHeaders support #359

merged 2 commits into from
Dec 11, 2022

Conversation

DoubleDi
Copy link
Contributor

@DoubleDi DoubleDi commented Nov 5, 2022 •
edited
Loading

This PR has 2 features:

  1. Supports dumping all the headers with the reqHeaders field
  2. Allows to specify your own log levels in a similar way to log messages

As a bonus it speeds up the middleware as the fields are not getting marshalled if the log won't be sent to the output

@efectn
Copy link
Member

efectn commented Nov 20, 2022

Can you check my comment @DoubleDi 🚀

@DoubleDi
Copy link
Contributor Author

@efectn Hi! Responded!

ReneWerner87
ReneWerner87 requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some changes

fiberzap/zap.go Outdated Show resolved Hide resolved
@ReneWerner87
Copy link
Member

look at it at the weekend

@ReneWerner87 ReneWerner87 merged commit cc64ed7 into gofiber:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@efectn efectn efectn approved these changes

Assignees
No one assigned
Labels
🧹 Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DoubleDi @efectn @ReneWerner87