Improving error handling with conflicting SN and PN's

[jasonyates]

If Netbox has multiple device types with the same Part Number the DeviceType.objects.get function throws an error. Same applies for devices with the same Serial Number. Neither condition should technically happen but Netbox doesn't treat PN or SN as unique so rather than throwing an exception, handle it gracefully.

[goebelmeier]

Are there any use cases for having different device types with the same part number?

[jasonyates]

In our environment we had various deployment options for UCS-C220-M5 servers pre-configured. Depending on the use case we may deploy one with an addon VIC card for example. Rather than adding the interfaces after the fact, we had some pre-configured device types that have the same base part number.

When syncing the EOX data it errors on these situations. I'm unsure if our use case is a valid one so rather than doing something like iterating through all of the PN's and updating them the PR handles the error more gracefully so the sync can continue.

We also hit an issue where 2 devices had been incorrectly configured with the same SN. That was correct but I updated to include more graceful error handling there too.