Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump dependencies and rust-toolchain #779

Merged
merged 11 commits into from
Aug 12, 2022
Merged

chore: bump dependencies and rust-toolchain #779

merged 11 commits into from
Aug 12, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Aug 9, 2022 •
edited
Loading

  • bump rust-toolchain to 1.63.0, required by ckb-vm-definitions v0.21.4
  • bump ckb dependencies to 0.104.0
  • bump ckb-vm to 0.21.3
  • bump other dependencies by cargo audit fix
  • bump blake2b-ref to 0.3.1
  • enable ckb-rocksdb march-native feature

@gw-bot

This comment was marked as outdated.

Sign in to view
@gw-bot

This comment was marked as outdated.

Sign in to view
@zeroqn zeroqn force-pushed the chore-bump-ckb-dependencies-and-rust-toolchain branch from a5b92b3 to b2c1fd4 Compare August 9, 2022 14:17
@gw-bot

This comment was marked as outdated.

Sign in to view
@blckngm
Copy link
Contributor

blckngm commented Aug 10, 2022

👍

There was a TransactionWithStatus shim (in gw-jsonrpc-types). Could it be removed now?

@gw-bot

This comment was marked as outdated.

Sign in to view
@zeroqn
Copy link
Contributor Author

zeroqn commented Aug 10, 2022

+1

There was a TransactionWithStatus shim (in gw-jsonrpc-types). Could it be removed now?

Removed in commit 84dc5bf

blckngm
blckngm previously approved these changes Aug 10, 2022
View reviewed changes
magicalne
magicalne previously approved these changes Aug 10, 2022
View reviewed changes
@jjyr
Copy link
Collaborator

jjyr commented Aug 10, 2022

Please use https://crates.io/crates/blake2b-ref/0.3.1

@zeroqn zeroqn dismissed stale reviews from magicalne and blckngm via 84140e1 August 10, 2022 09:51
@gw-bot
Copy link

gw-bot bot commented Aug 10, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2831687834

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@zeroqn
Copy link
Contributor Author

zeroqn commented Aug 10, 2022

Please use https://crates.io/crates/blake2b-ref/0.3.1

bump in 84140e1

@zeroqn
Copy link
Contributor Author

zeroqn commented Aug 11, 2022

I think we can wait rust 1.63 (will be released tonight).

jjyr
jjyr previously approved these changes Aug 11, 2022
View reviewed changes
@blckngm
Copy link
Contributor

blckngm commented Aug 11, 2022

If we update rocksdb, we should use the march-native feature.

@zeroqn
Copy link
Contributor Author

zeroqn commented Aug 11, 2022

If we update rocksdb, we should use the march-native feature.

This pr ?

@blckngm
Copy link
Contributor

blckngm commented Aug 11, 2022

ckb-rocksdb 0.18.3 with march-native targets the native CPU, like 0.18.1:

nervosnetwork/rust-rocksdb#41

We only use PORTABLE=1 SSE=1 when building docker image.

Flouse
Flouse previously approved these changes Aug 12, 2022
View reviewed changes
@Flouse Flouse added the dependencies Pull requests that update a dependency file label Aug 12, 2022
@zeroqn zeroqn dismissed stale reviews from Flouse and jjyr via 94e79b1 August 12, 2022 05:46
@gw-bot
Copy link

gw-bot bot commented Aug 12, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2844740422

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@zeroqn
Copy link
Contributor Author

zeroqn commented Aug 12, 2022

ckb-rocksdb 0.18.3 with march-native targets the native CPU, like 0.18.1:

nervosnetwork/rust-rocksdb#41

We only use PORTABLE=1 SSE=1 when building docker image.

enable march-native feature in 94e79b1

@jjyr jjyr requested review from blckngm and Flouse August 12, 2022 08:06
@jjyr jjyr merged commit 8f83d91 into godwokenrises:develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@jjyr jjyr jjyr approved these changes

@magicalne magicalne magicalne left review comments

@Flouse Flouse Awaiting requested review from Flouse

Assignees

@zeroqn zeroqn

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeroqn @blckngm @jjyr @Flouse @magicalne