Decouple block producing, submission and confirming #776

blckngm · 2022-08-02T10:03:13Z

Don't wait for the confirmation of the previous L2 block before generating or submitting the next block.

New config introduced in this PR:

# Block producing and submission.
[block_producer]
# Max number of local blocks.
local_limit = 3
# Max number of submitted (but not confirmed) blocks.
submitted_limit = 3
# Minimal delay between blocks.
block_interval_secs = 7

# Deposit collection criteria.
[mem_pool.mem_block]
deposit_block_timeout = 150
deposit_timestamp_timeout = 1200000
deposit_epoch_timeout = 1
deposit_minimal_blocks = 0

# P2P network identification and authentication.
[p2p_network_config]
secret_key_path = "path to p2p secret key"
allowed_peer_ids = ["peer1", "peer2"]

instead of producing block.

Tests still do not pass

Just use FinalizedCustodianCapacity

…ducing-and-submitting

And update last confirmed/submitted transaction when syncing from L1

gw-bot · 2022-09-20T02:42:51Z

Running integration test

Workflow Run Id: 3087062311

Components:

prebuilds: 1.6.1-202209140948,1.6.1
godwoken: 381751d
scripts: prebuilds 430247e
polyjuice: prebuilds 1d05a58
kicker: 155cfdf
tests: 141852d

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

A node become not live if it hasn't produced, received, submitted or confirmed a block in a while.

gw-bot · 2022-09-21T06:34:38Z

Running integration test

Workflow Run Id: 3095672858

Components:

prebuilds: 1.6.1-202209140948,1.6.1
godwoken: 1868fd6
scripts: prebuilds 430247e
polyjuice: prebuilds 1d05a58
kicker: 60bc812
tests: 141852d

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

crates/block-producer/src/block_sync_client.rs

crates/block-producer/src/psc.rs

crates/p2p-network/client-key

jjyr · 2022-09-21T10:39:22Z

docs/p2p_sync.md

+node_mode = "fullnode"
+
+[p2p_network_config]
+listen = "/ip4/0.0.0.0/tcp/9999"


Replace the example with a p2p multiaddr version?

I have added doc about authentication (including key generation, peer id calculation and related configurations).

gw-bot · 2022-09-21T11:30:01Z

Running integration test

Workflow Run Id: 3097432976

Components:

prebuilds: 1.6.1-202209140948,1.6.1
godwoken: 9d61cf6
scripts: prebuilds 430247e
polyjuice: prebuilds 1d05a58
kicker: 60bc812
tests: 141852d

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

gw-bot · 2022-09-21T11:59:13Z

Running integration test

Workflow Run Id: 3097610689

Components:

prebuilds: 1.6.1-202209140948,1.6.1
godwoken: c77d733
scripts: prebuilds 430247e
polyjuice: prebuilds 1d05a58
kicker: 60bc812
tests: 141852d

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

crates/block-producer/src/psc.rs

crates/chain/src/chain.rs

crates/block-producer/src/block_sync_client.rs

in block_sync_client

gw-bot · 2022-09-22T05:58:52Z

Running integration test

Workflow Run Id: 3103162638

Components:

prebuilds: 1.6.1-202209140948,1.6.1
godwoken: 1a04847
scripts: prebuilds 430247e
polyjuice: prebuilds 1d05a58
kicker: 60bc812
tests: 141852d

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

gw-bot · 2022-09-22T06:56:17Z

Running integration test

Workflow Run Id: 3103419873

Components:

prebuilds: 1.6.1-202209140948,1.6.1
godwoken: fcff0de
scripts: prebuilds 430247e
polyjuice: prebuilds 1d05a58
kicker: 60bc812
tests: 141852d

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

jjyr · 2022-09-22T11:04:08Z

@sopium Please resolve conflicts

blckngm · 2022-09-22T11:08:02Z

@sopium Please resolve conflicts

Github UI and local git merge are not showing any conflicts?

jjyr · 2022-09-22T12:51:13Z

@sopium Please resolve conflicts

Github UI and local git merge are not showing any conflicts?

Right, GitHub display conflicts under the option 'rebase and merge', but we can create a new merge. Congratulate @sopium !, finally get it done.

blckngm added 30 commits June 7, 2022 19:46

feat: decouple block producing and submitting

8d7c9bb

it seem to work

5863de2

handle local stake cells, etc.

2f22244

check tx input on first send error too

f20794d

rebase

83258dc

refactor local cells manager

28f7eab

Refactor cell query

d5af582

fix cells

ed09c82

lock block collected deposit and custodian cells

812dd85

lock block input cells

e782c12

fix stuff after rebase

091d49c

Collect custodian cells when submitting

c915c2b

instead of producing block.

fix stuff after rebase

c3f190e

fix tests compilation

61c4a41

Tests still do not pass

Fix deposit and withdrawal tests

e3c24d6

Simplify collecting custodian capacity from the last finalized block

b4aaca7

refactor: remove AvailableCustodians

69eebcd

Just use FinalizedCustodianCapacity

Calculate remaining capacity when output mem block

5fe1ae5

Merge branch 'develop' into decouple-block-producing-and-submitting

803806d

Merge remote-tracking branch 'origin/develop' into decouple-block-pro…

34368b4

…ducing-and-submitting

WIP: L1 sync

d02b89c

Merge branch 'develop' into decouple-block-producing-and-submitting

b25325f

revert blocks if input becomes dead

6885d59

Remove db L2BlockCommittedInfo

72493dd

Store finalized custodians when syncing from L1

4e20e2b

refactor jsonrpc client error handling

e114966

Graceful shutdown for psc task

4271da0

Reset mem pool in psc init

08ca37d

Store genesis block submit tx and last submitted/confirmed

3ba50d9

Handle transactions before the last found one

010a75c

And update last confirmed/submitted transaction when syncing from L1

Add built-in liveness probe (/livez)

1868fd6

A node become not live if it hasn't produced, received, submitted or confirmed a block in a while.

jjyr reviewed Sep 21, 2022

View reviewed changes

blckngm added 3 commits September 21, 2022 19:29

Fix typo

7c5d5ac

psc: dedup deposit asset scripts

c705c71

Move p2p example keys to examples/

9d61cf6

p2p sync doc: add peer id authentication docs

c77d733

zeroqn reviewed Sep 22, 2022

View reviewed changes

crates/block-producer/src/psc.rs Show resolved Hide resolved

zeroqn reviewed Sep 22, 2022

View reviewed changes

crates/block-producer/src/psc.rs Show resolved Hide resolved

zeroqn reviewed Sep 22, 2022

View reviewed changes

crates/chain/src/chain.rs Outdated Show resolved Hide resolved

zeroqn reviewed Sep 22, 2022

View reviewed changes

crates/block-producer/src/block_sync_client.rs Outdated Show resolved Hide resolved

zeroqn previously approved these changes Sep 22, 2022

View reviewed changes

blckngm added 3 commits September 22, 2022 13:34

Use biased select in psc loop

291d308

Remove XXX comment

f766e83

Use mutex instead of unbounded channel for p2p stream

1a04847

in block_sync_client

blckngm dismissed zeroqn’s stale review via 1a04847 September 22, 2022 05:58

psc: resend transaction after 24s

fcff0de

zeroqn approved these changes Sep 22, 2022

View reviewed changes

jjyr approved these changes Sep 22, 2022

View reviewed changes

jjyr merged commit 1a049b6 into develop Sep 22, 2022

jjyr deleted the decouple-block-producing-and-submitting branch September 22, 2022 12:49

Flouse mentioned this pull request Nov 7, 2022

mainnet_v1: bump to godwoken-prebuilds:1.7.0-poly.1.4.5 and web3 1.8.6 godwokenrises/godwoken-info#75

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decouple block producing, submission and confirming #776

Decouple block producing, submission and confirming #776

blckngm commented Aug 2, 2022 •

edited

Loading

gw-bot bot commented Sep 20, 2022 •

edited

Loading

gw-bot bot commented Sep 21, 2022 •

edited

Loading

jjyr Sep 21, 2022

blckngm Sep 21, 2022

gw-bot bot commented Sep 21, 2022 •

edited

Loading

gw-bot bot commented Sep 21, 2022 •

edited

Loading

gw-bot bot commented Sep 22, 2022 •

edited

Loading

gw-bot bot commented Sep 22, 2022 •

edited

Loading

jjyr commented Sep 22, 2022

blckngm commented Sep 22, 2022

jjyr commented Sep 22, 2022

Decouple block producing, submission and confirming #776

Decouple block producing, submission and confirming #776

Conversation

blckngm commented Aug 2, 2022 • edited Loading

gw-bot bot commented Sep 20, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Sep 21, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

jjyr Sep 21, 2022

Choose a reason for hiding this comment

blckngm Sep 21, 2022

Choose a reason for hiding this comment

gw-bot bot commented Sep 21, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Sep 21, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Sep 22, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

gw-bot bot commented Sep 22, 2022 • edited Loading

Running integration test

Components:

Manually running integration test

Run Result

jjyr commented Sep 22, 2022

blckngm commented Sep 22, 2022

jjyr commented Sep 22, 2022

blckngm commented Aug 2, 2022 •

edited

Loading

gw-bot bot commented Sep 20, 2022 •

edited

Loading

gw-bot bot commented Sep 21, 2022 •

edited

Loading

gw-bot bot commented Sep 21, 2022 •

edited

Loading

gw-bot bot commented Sep 21, 2022 •

edited

Loading

gw-bot bot commented Sep 22, 2022 •

edited

Loading

gw-bot bot commented Sep 22, 2022 •

edited

Loading