Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RPC get_pending_tx_hashes #772

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Add RPC get_pending_tx_hashes #772

merged 2 commits into from
Aug 9, 2022

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Jul 28, 2022 •
edited by Flouse
Loading

New RPC gw_get_pending_tx_hashes

Get pending transaction hashes, which means a developer could get the mem_pool transactions of Godwoken.

@gw-bot
Copy link

gw-bot bot commented Jul 28, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2751034631

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@jjyr
Copy link
Collaborator

jjyr commented Jul 28, 2022

LGTM, can we turn this into 'Ready for review'?

@blckngm blckngm marked this pull request as ready for review July 29, 2022 03:01
@gw-bot
Copy link

gw-bot bot commented Jul 29, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2758057297

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@Flouse Flouse requested review from jjyr and classicalliu July 29, 2022 06:14
@classicalliu
Copy link
Contributor

Does readonly node support this RPC ?

@blckngm
Copy link
Contributor Author

blckngm commented Jul 29, 2022

Does readonly node support this RPC ?

Read-only node needs p2p sync to actually support this, or the list returned will always be empty.

@Flouse Flouse requested a review from RetricSu August 1, 2022 04:07
@classicalliu classicalliu mentioned this pull request Aug 9, 2022
Merged
@jjyr jjyr merged commit 0f1fd6f into godwokenrises:develop Aug 9, 2022
@Flouse Flouse mentioned this pull request Aug 30, 2022
Merged
@blckngm blckngm deleted the get-pending-tx branch September 26, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@jjyr jjyr jjyr approved these changes

@classicalliu classicalliu classicalliu approved these changes

@RetricSu RetricSu Awaiting requested review from RetricSu

Assignees

@blckngm blckngm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blckngm @jjyr @classicalliu @Flouse