Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(rpc server): submit withdrawal missing data for submit_tx #770

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Jul 25, 2022

Change

  • fix(rpc-server): missing data for Data<mpsc::Sender<(InQueueRequestHandle, Request)>>
  • feat(rpc-server): gw_submit_withdrawal_request_finalized_custodian_unchecked rpc method for test, enable by RPCMethods::Test
  • refactor(rpc-server): submit_withdrawal_request, skip check finalized custodian for gw_submit_withdrawal_request_finalized_custodian_unchecked

Describe the bug

gw_submit_withdrawal_request reuturn Internal Error

To Reproduce

Steps to reproduce the behavior:
cURL CMD:

curl 'https://godwoken-testnet-v1.ckbapp.dev/' \
  -H 'content-type: application/json' \
  --data-raw '{"jsonrpc":"2.0","id":6745565,"method":"gw_submit_withdrawal_request","params":["0x400100000c000000f5000000e90000000c000000a400000011000000e91601000000000000e8764817000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000aea8e18bfd509331b6a6414c9335adfac35f0da8d474d3f8fa422cb6e54a7f0f02000000b585adc922e4861180d4afe1f919c0a21fa9fb810d9b892174a5f2a6a0b64d630000000000000000000000000000000041000000725987129d936f1d14716121fbd850514ece326b4e5950a96bea26873f88b1b212c96eae75569259fdf7226fe1413c269ba52d24affe136394c5ff7d406b77a61c4b00000010000000300000003100000079f90bb5e892d80dd213439eeab551120eb417678824f282b4ffb5f21bad2e1e011600000001d1667cbf1cc60da94c1cf6c9cfb261e71b6047f700"]}' \
  --compressed

# Result
{"jsonrpc":"2.0","id":6745565,"error":{"code":-32603,"message":"Internal Error"}}

@gw-bot

This comment was marked as outdated.

@gw-bot
Copy link

gw-bot bot commented Jul 25, 2022

Running integration test

Workflow Run Id: 2732268886

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@Flouse Flouse requested review from blckngm, jjyr and keroro520 and removed request for blckngm July 26, 2022 04:13
@jjyr jjyr merged commit 396a319 into godwokenrises:1.4-rc Jul 26, 2022
Flouse added a commit to godwokenrises/godwoken-docker-prebuilds that referenced this pull request Jul 26, 2022
jjyr pushed a commit to godwokenrises/godwoken-docker-prebuilds that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants