fix: Cancel zero address as the default from address #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
reviewed
May 25, 2023
| @@ -437,7 +432,7 @@ function toApiNodeInfo(nodeInfo: GwNodeInfo): NodeInfo { | |||
| return snakeToCamel(nodeInfo, ["code_hash", "hash_type"]); | |||
| } | |||
|
|
|||
| async function zeroAddressAccount( | |||
| async function _zeroAddressAccount( | |||
There was a problem hiding this comment.
Please delete this function.
Flouse
reviewed
May 25, 2023
| @@ -237,11 +236,6 @@ export class GwConfig { | |||
| private async fetchDefaultFromAccount( | |||
There was a problem hiding this comment.
This comment // Using zero address firstly could be deleted?
Flouse
previously approved these changes
May 25, 2023
jjyr
approved these changes
May 25, 2023
Flouse
approved these changes
May 25, 2023
Merged
This was referenced Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Possible reorg detected#1067zero address deposited in godwoken block 372398, so when
eth_callrequires execute before this block and use zero address as default from will failedSo using first EOA account as default from address will resolve the problem