-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mainnet_v1: bump to Godwoken/Web3 Web3-Indexer v1.12.0 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Tl
requested review from
Flouse and
jjyr
and removed request for
Flouse
February 28, 2023 12:23
Flouse
requested changes
Feb 28, 2023
Flouse
requested changes
Feb 28, 2023
Simon-Tl
changed the title
mainnet_v1: bump to Godwoken v1.12.0
mainnet_v1: bump to Godwoken v1.12.0 Web3/Web3Indexer v1.12.0-rc1
Feb 28, 2023
Co-authored-by: Flouse <flouse@gmail.com>
Flouse
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, godwoken:v1.12.0 can use ckb-builtin-indexer.
Simon-Tl
changed the title
mainnet_v1: bump to Godwoken v1.12.0 Web3/Web3Indexer v1.12.0-rc1
mainnet_v1: bump to Godwoken/Web3 Web3-Indexer v1.12.0
Feb 28, 2023
Flouse
approved these changes
Mar 1, 2023
jjyr
reviewed
Mar 1, 2023
Flouse
requested changes
Mar 1, 2023
execute_l2tx_max_cycles = 3000000000
Flouse
approved these changes
Mar 1, 2023
jjyr
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes
The consensus-related options were moved into consensus config, and the builtin mainnet consensus were put into the godwoken binary. This change reduces the operation works of node maintainers
eth_getFilterLogs
should return all matched logs godwoken#947Detailed Release notes
https://github.com/godwokenrises/godwoken/releases
Changed Configs
support CKB build-in indexer
If a CKB indexer RPC url is explicitly specified, we assume that we are connecting to a standalone indexer.
Otherwise we just use CKB RPC url and assume that we are connecting to CKB builtin indexer.
introduced mainnet builtin consensus config
[dynamic_config.fee_config] -> [mem_pool.fee]
[dynamic_config.rpc_config] -> [mem_pool.extra]