added rpc mode decorators #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBelousov
commented
Aug 23, 2020
MichaelBelousov
commented
- tested on a local project,
- supports decorating methods (rpc) and properties (rset) with the same decorators
- JSDoc comments are copied from godot.d.ts's generated comments with minor changes
|
this PR resolves issue #31 |
|
Here is a minimal test project: |
|
Will do tomorrow |
|
Whoops sorry forgot, really busy with moving right now but I will get to this very soon. |
|
@Geequlim I think that should be good now |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.