Skip to content

Changed gen-files' encoding to UTF-8 and updated README.md #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Changed gen-files' encoding to UTF-8 and updated README.md #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e55f410
Changed encoding of generated source files to UTF-8
Teashrock Mar 4, 2020
8bf4c68
Actualized information
Teashrock Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ It is also possible to replace the ECMAScript engine like V8 or SpiderMonkey but
### Compile
* Clone the source code of [godot](https://github.com/godotengine/godot)
* Clone this module and put it into `godot/modules/` and make sure the folder name of this module is `ECMAScript`
* [Recompile godot engine](https://docs.godotengine.org/en/3.0/development/compiling/index.html)
* [Recompile godot engine](https://docs.godotengine.org/en/3.2/development/compiling/index.html) <b>(Only MinGW is supported on Windows for now!)</b>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using **Bold content** in markdown instead of <b></b>


### Usage

Expand Down
4 changes: 2 additions & 2 deletions SCsub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ sources = [
]

if env['tools']:
with open("tools/godot.d.ts.gen.cpp", "w") as f:
with open("tools/godot.d.ts.gen.cpp", "w", encoding="utf-8") as f:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python2 does not support this kind of syntax. Which is the default python version on macOS.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godot 3.2 is now only compileable with Python 3.5+
http://docs.godotengine.org/en/3.2/development/compiling/compiling_for_osx.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only on Mac OS X, other systems too. So, now there is no need to remake that for Python 2.

text = '/* THIS FILE IS GENERATED DO NOT EDIT */\n#include "editor_tools.h"\nString ECMAScriptPlugin::BUILTIN_DECLEARATION_TEXT = \n${source};';
f.write(text.replace('${source}', dump_text_file_to_cpp("misc/godot.d.ts")))
with open("tools/tsconfig.json.gen.cpp", "w") as f:
with open("tools/tsconfig.json.gen.cpp", "w", encoding="utf-8") as f:
text = '/* THIS FILE IS GENERATED DO NOT EDIT */\n#include "editor_tools.h"\nString ECMAScriptPlugin::TSCONFIG_CONTENT = \n${source};'
f.write(text.replace('${source}', dump_text_file_to_cpp("misc/tsconfig.json")))
env_module.add_source_files(env.modules_sources, 'tools/*.cpp')
Expand Down