Allow WASAPI multi-channel microphone input #99875
Conversation
| } else if (ad->audio_input.channels >= 2) { | ||
| int channels = ad->audio_input.channels; | ||
| for (int ch = 0; ch < channels - 1; ch++) { | ||
| int32_t sample = read_sample(ad->audio_input.format_tag, ad->audio_input.bits_per_sample, data, j * channels + ch); |
Support multi-channel microphone input by downmixing to stereo - Enhanced the WASAPI audio driver to support microphones with any number of channels. - This modification ensures compatibility with a broader range of multi-channel microphones, allowing for more versatile input handling in Godot. Co-Authored-By: Shatyuka <shatyuka@qq.com>
fire
force-pushed
the
vsk-multi-audio-input-4.4
branch
from
79ef794 to
6ad97f7
Compare
|
I have a microphone with two audio inputs (outputs) https://zoomcorp.com/en/ca/handheld-recorders/handheld-recorders/h3-vr-360-audio-recorder/ but still need to set up to test this. |
| @@ -849,7 +849,7 @@ void AudioDriverWASAPI::thread_func(void *p_udata) { | |||
|
|
|||
| // fixme: Only works for floating point atm | |||
| for (UINT32 j = 0; j < num_frames_available; j++) { | |||
| int32_t l, r; | |||
| int32_t l = 0, r = 0; | |||
There was a problem hiding this comment.
It's super rare in the codebase to initialize multiple variables on the same line. And they are single letter variables too. We could take this opportunity to rename them.
| int32_t l = 0, r = 0; | |
| int32_t left = 0; | |
| int32_t right = 0; |
| } else if (ad->audio_input.channels >= 2) { | ||
| int channels = ad->audio_input.channels; | ||
| for (int ch = 0; ch < channels - 1; ch++) { | ||
| int32_t sample = read_sample(ad->audio_input.format_tag, ad->audio_input.bits_per_sample, data, j * channels + ch); |
| if (ch % 2 == 0) { | ||
| r += sample; | ||
| } else { | ||
| l += sample; | ||
| } |
There was a problem hiding this comment.
From what I know, the assumption is naive. Like, depending on the number of channels, sometimes it's left, right, or even center.
|
Came from #99989, I'm glad to see that people are trying to find a solution to this problem. I don't know enough about this area to be able to help, but I'll be the first to give you some feedback 👍 |
Salvaging #96947
Support multi-channel microphone input by downmixing to stereo
Enhanced the WASAPI audio driver to support microphones with any number of channels.
This modification ensures compatibility with a broader range of multi-channel microphones, allowing for more versatile input handling in Godot.