Add DirAccess interface to file_access_memory #99851
Open
+349
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolke
force-pushed
the
memdiraccess
branch
2 times, most recently
from
1fa1c9c to
0e09b80
Compare
|
This will be failing sanitizers until #99847 |
|
#99847 is now merged, so the CI succeeds |
demolke
force-pushed
the
memdiraccess
branch
from
e574aa2 to
96f8fff
Compare
adamscott
reviewed
Dec 17, 2024
demolke
force-pushed
the
memdiraccess
branch
from
96f8fff to
51cb1a2
Compare
Having memory backed res:// folder is useful for hermetic tests that need to mutate contents of the resource directory. For example in godotengine#98909 we want the res:// folder not to contain a texture imported on previous run to always test the same code path. It requires changes to core/os/os.h so that we can re-initialize the file/dir handlers during test setup.
demolke
force-pushed
the
memdiraccess
branch
from
51cb1a2 to
8b2b870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having memory backed res:// folder is useful for hermetic tests that need to mutate contents of the resource directory.
For example in #98909 we want the res:// folder not to contain a texture imported on previous run to always test the same code path.
It requires changes to core/os/os.h so that we can re-initialize the file/dir handlers during test setup.