Implement move_to_trash to Web platform
#99769
Open
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Nov 28, 2024
platform/web/os_web.cpp
Outdated
Comment on lines
270
to
272
| if (file_name.length() > 240) { | ||
| file_name = file_name.substr(0, file_name.length() - 15); | ||
| } |
There was a problem hiding this comment.
If the ID number below is 99 at most, shouldn't the length check be 253 characters instead (since 99 is 2 characters)?
There was a problem hiding this comment.
Ah, that's correct! I took this code directly without any changes from platform/linuxbsd/os_linuxbsd.cpp. Will update it accordingly, thanks for pointing that out..
khairul169
force-pushed
the
feat/imp-web-move-to-trash
branch
from
d03a599 to
6b74713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
move_to_trashfor the web platform, enabling the web editor to delete or move files to trash.If the filesystem is not persistent, the file will be permanently deleted.
Fixes #70975