Fix incorrect Z direction for AABB's position #99352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
added
bug
documentation
cherrypick:4.2
Flarkk
reviewed
Nov 17, 2024
Mickeon
force-pushed
the
documentation-aabb-coords-are-complicated
branch
from
9d2fdca to
cd80068
Compare
AThousandShips
approved these changes
Nov 22, 2024
aaronfranke
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Please be mindful of the precise terminology. As of Godot 4.1 we have separate concepts of forward/back direction and front/rear sides (Vector3 MODEL_* constants). We need to pick one of these wordings and use it consistently:
- Forward -Z and back +Z.
- Front +Z and rear -Z.
However, we should consider just mentioning directly that position is in the negative corner, -X -Y -Z, and end is in the positive corner, +X +Y +Z.
Mickeon
force-pushed
the
documentation-aabb-coords-are-complicated
branch
from
cd80068 to
6e01c03
Compare
aaronfranke
requested changes
Nov 22, 2024
Mickeon
force-pushed
the
documentation-aabb-coords-are-complicated
branch
from
6e01c03 to
d143f25
Compare
aaronfranke
reviewed
Nov 22, 2024
Mickeon
force-pushed
the
documentation-aabb-coords-are-complicated
branch
from
d143f25 to
e0b1300
Compare
aaronfranke
approved these changes
Nov 22, 2024
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot-docs#9598
Comes from #87114 (oops)