Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obstacle avoidance and 3D editor ignoring transform #99176

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix obstacle avoidance and 3D editor ignoring transform #99176

merged 1 commit into from
Nov 18, 2024
+79 −34

Conversation

tracefree
Copy link
Contributor

@tracefree tracefree commented Nov 13, 2024 •
edited
Loading

Follow up PR to #96730, #93059, and #99030

  • Update the new NavigationObstacle3D editor plugin debug visuals to respect the node transform
  • Fix oversight of my previous PRs where the obstacle's node transform is ignored when registering its vertices on the NavigationServer
  • Clean up, optimize, and comment code (done, but could probably be improved further)

@Chaosus Chaosus added this to the 4.x milestone Nov 13, 2024
@tracefree tracefree force-pushed the obstacle_transform branch 3 times, most recently from 0968dce to 0d938bd Compare November 15, 2024 11:59
@tracefree tracefree marked this pull request as ready for review November 15, 2024 12:09
@tracefree tracefree requested review from a team as code owners November 15, 2024 12:09
@tracefree tracefree force-pushed the obstacle_transform branch 3 times, most recently from 005a96c to 03797a4 Compare November 15, 2024 13:16
@smix8 smix8 modified the milestones: 4.x, 4.4 Nov 15, 2024
@tracefree tracefree mentioned this pull request Nov 15, 2024
Merged
@Repiteo Repiteo merged commit 8d530bc into godotengine:master Nov 18, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2024

Thanks!

@tracefree tracefree deleted the obstacle_transform branch November 18, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@smix8 smix8 smix8 approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:navigation topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@tracefree @Repiteo @smix8 @AThousandShips @Chaosus