Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Copy encryption and script settings on export preset duplication. #98739

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[Editor] Copy encryption and script settings on export preset duplication. #98739

merged 1 commit into from
Dec 2, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 1, 2024

Fixes #98722

@bruvzg bruvzg added this to the 4.4 milestone Nov 1, 2024
@bruvzg bruvzg requested a review from a team as a code owner November 1, 2024 22:04
KoBeWi
KoBeWi approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as a fix for now, but there has to be a better (more reliable) way to do it. I also checked the implementation of the setters and they save all presets each time you change anything.

@akien-mga akien-mga merged commit 872681c into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:export
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Duplicating export preset doesn't copy over GDScript Export Mode
4 participants
@bruvzg @akien-mga @adamscott @KoBeWi