Include full Apache-2.0 license in COPYRIGHT.txt #98628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Oct 29, 2024
matmas
force-pushed
the
full-apache-license
branch
from
71bbca6 to
4ea988f
Compare
Calinou
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Looks good to me.
Regarding whether to keep the "How to apply the Apache License to your work" section, I'd keep it in for reasons similar to the one described for the GPL: https://www.gnu.org/licenses/gpl-faq.html#GPLOmitPreamble
|
Thanks! Congratulations on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89548
Note: Instructions on how to apply the license to source code headers are not part of the license itself but sometimes people include it too. To me it seemed best to omit it here but I don't have a strong opinion on it.